Ondeviceready being fired twice, Cordova (Phonegap) 2.6/2.7, Enyo 2.2

pmarsh

This is bubbled up off IRC where sugardave said he didn't see this issue with the sampler and Cordova (phonegap) 2.6. (I had been using Phonegap 2.7) I bundled up the sampler and 2.6 and still saw the event fire twice. I wanted to post and see if perhaps my implementation is out of date.

Edit: Dave had to go deal with actual work, don't want to seem like I ignored him

We are not using the phonegap package from the extras as it seems that is now baked into enyo itself.

index.html:

enyo.dispatcher.listen(document, "deviceready");
new App().renderInto(document.body);

App.js

enyo.kind({
  name: "App",
  kind: "FittableRows",
  components [
    {kind: "Signals", ondeviceready: "deviceReady" }
  ],
  deviceReady: function() {
    //Appears twice in the logs
    //Using other calls like navigator.notification results in two as well
    enyo.log("device ready");
  }
});

unwiredben

The phonegap.js file in Enyo's core already does the enyo.dispatcher.listen(document, "deviceready") call for you, so in effect, you've now setup two listeners for it, both of which cause the signal to fire.

inta

I think you do not need the enyo.dispatcher.listen if you include the Signals kind for deviceready.

arthur

The reason the event is firing twice is that the PhoneGap events are already being listened for (including deviceready): https://github.com/enyojs/enyo/blob/master/source/dom/phonegap.js

sugardave

Clarification, I'm not seeing it in another internal project I'm working, not Sampler

@inta, you are right, at least with top-of-tree Enyo and Cordova 2.6, you only need the enyo.Signals declaration

@pmarsh, I should have assumed you had that call to enyo.dispatcher, oops!

pmarsh

Thanks for the replies!

I yanked out the dispatcher call thinking perhaps it wasn't needed, but I could have sworn I still got the double calls.

However I had a lot open so I could have messed it up. I'll re-do it in the morning and post an update.

pmarsh

Yup I was editing the wrong index.html, removing the enyo.dispatcher call stopped the doubling up.

Unfortunately it doesn't seem you can't do pull requests on the github wiki or I'd update the docs

unwiredben

ah, that's a very old page at https://github.com/enyojs/enyo/wiki/PhoneGap-Native-Functions -- I'll get our docs guy to update this.